Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add darwin arm64 support #16

Merged
merged 1 commit into from
Jun 16, 2022
Merged

add darwin arm64 support #16

merged 1 commit into from
Jun 16, 2022

Conversation

JingeXC
Copy link

@JingeXC JingeXC commented Feb 15, 2022

ffprobe-static was not working on my mac(apple silicon m1).Then I found the problem was that the darwin arm64 binary not exist.
In this pull request the darwin arm64 binary is added to support apple silicon m1.

@johnnyshankman
Copy link

johnnyshankman commented Feb 16, 2022

This looks great to me 👍 @joshwnj any feedback?

Would love to release this ASAP. Catches the got-ya with the conditional for reporting unsupported architecture and adds the binary in the right spot. At most, we just need someone to verify this binary is the official correct binary for ff.

@kabojnk
Copy link

kabojnk commented Feb 24, 2022

LGTM too. @joshwnj Any way we can get an approval on this? Also waiting for this and is preferable than having our own fork build. Thanks!

@johnnyshankman
Copy link

johnnyshankman commented Mar 8, 2022

Bump @joshwnj I've made an update here where I document where the binary came from in case that's what's holding us up
#17

@joshwnj
Copy link
Collaborator

joshwnj commented Jun 16, 2022

Thanks @JingeXC , @kabojnk and @johnnyshankman and my apologies for the silence on this, life has gotten very busy :)

I'm merging this now.

I'll also be opening an issue to discuss transferring ownership of the project, as I don't use it anymore and ideally we want the owners to have a stake in it.

@joshwnj joshwnj merged commit 06f3760 into derhuerst:master Jun 16, 2022
@joshwnj
Copy link
Collaborator

joshwnj commented Jun 16, 2022

If anyone is interested, please make a reply to the thread here: #18

elliotsayes added a commit to elliotsayes/ffprobe-static that referenced this pull request Dec 12, 2022
Update documentation to reflect derhuerst#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants